Add interactive to other mz layers #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added interactive for the following mz sdk layers: - `mz_current_location_gem`, - `mz_dropped_pin`, - `mz_default_line` - `mz_default_polygon`
|
@tallytalwar Thanks for the correction. All these styles used to have For packaging – Just make PRs for the "default" Github repo (not the |
nvkelso
approved these changes
May 22, 2017
This was referenced May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interactive for the following mz sdk layers:
mz_current_location_gem,mz_dropped_pin,mz_default_linemz_default_polygonWhile updating the mapzen android sdk to use latest tangram-es release, @sarahlensing and I found that we need to have interactivity set for custom MapData. We already had this for
pointdata layers, but will also make sense forpolygonandpolylinedata layers. Along with that I think it does make sense to have interactivity set formz_current_location_gem.Along with this it might make sense to have
interactiveset formz_route_line,mz_route_line_dash,mz_route_line_transitto provide functionality of user picking one of multiple routes. (This has a dependency currently on valhalla functionality, I think we do not have valhalla functionality to get multiple routes). Also maybe have it set formz_route_transit_stop, again dependent on valhalla functionality. I have not made any changes for this in this PR.@nvkelso I am not sure how you propagate these to different variants of a style sheet. Let me know if its manual, then will update other bubble-wrap variant yaml files. Will also file a PR for other house styles once we have a consensus here.
With respect to using this in the upcoming version of android and ios sdk, me and @sarahlensing were thinking if we can have a patched release of 7.0.1 with these changes. @nvkelso thoughts on this?